Improved performance of power manifold creation and more #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_component` on product manifold
kellertuer
approved these changes
Aug 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 31 31
Lines 3292 3294 +2
=======================================
+ Hits 3289 3291 +2
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ManifoldsBase.jl improvements that are needed for better performance of IPM.
Note: constraints are creating new PowerManifolds at every access and these constructors were type-unstable before these changes, creating significant slowdowns.
get_component(M::ProductManifold, p, i)with integers is still slow and I didn't really want to sprinkle everything withBase.@constprop :aggressiveto try to improve it.